nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
382 stars 114 forks source link

fix: conceal error if AUTH_CONCEAL_ERRORS is set #445

Closed ErwinPetit closed 10 months ago

ErwinPetit commented 10 months ago

Before submitting this PR:

Checklist

Changes

When AUTH_CONCEAL_ERRORS is used, the error code in the response is also concealed

Tests

Snapshot for conceal-error.test.ts has been updated

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 7b13513a866d3499662a340aabee02a916450fa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | hasura-auth | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dbarrosop commented 10 months ago

Thanks for the PR @ErwinPetit

LGTM @onehassan anything to add?

onehassan commented 10 months ago

LGTM! Thanks for the PR @ErwinPetit 🙌 . I'll add a changeset and merge!

onehassan commented 10 months ago

@ErwinPetit it seems I can't push to your repo, can you unlock your main branch?

image
ErwinPetit commented 10 months ago

Oops sorry @onehassan . I unlocked the branch, it might be good !

onehassan commented 10 months ago

Yes that worked - thanks @ErwinPetit 👍