nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
373 stars 111 forks source link

feat: allow connecting social logins to existing users even if emails don't match #459

Closed dbarrosop closed 3 months ago

dbarrosop commented 6 months ago

When calling /oauth/:provider adds a new query arg connect which needs to contain a valid JWT. If the social login doesn't already exist, sign-ins successfully and the JWT belongs to a valid user, the social login is connected to the user even if the email addresses don't match.

Before submitting this PR:

Checklist

Breaking changes

Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.

Tests

Documentation

Please make sure the documentation is updated accordingly, in particular:

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: ab841a2165b768a75962a6be4bad0352022d4c3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | hasura-auth | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR