nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
373 stars 111 forks source link

WIP attempt at modification for allowing extraClaims during signin #486

Closed wollerman closed 3 months ago

wollerman commented 3 months ago

Before submitting this PR:

Checklist

Breaking changes

Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.

Tests

Documentation

Please make sure the documentation is updated accordingly, in particular:

dbarrosop commented 3 months ago

Please, if you want to contribute a feature open an issue first to describe the use-case and security implications (if any). For instance, the code I am seeing here is not secure as anyone could spoof claims.

wollerman commented 3 months ago

Thanks for taking a look so quickly! It was mostly a POC to understand if it could be bubbled up. You suggested Apollo client or cookies in discord, so I'm going to explore that route.

Thanks again!