nhost / hasura-auth

Authentication for Hasura.
https://nhost.io
MIT License
372 stars 110 forks source link

fix: now supporting allowed email/domain combo rules #508

Closed xmlking closed 2 months ago

xmlking commented 2 months ago

Before submitting this PR:

Checklist

Breaking changes

Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.

Tests

Documentation

Please make sure the documentation is updated accordingly, in particular:

Now supporting combination of allowed email/domain rules as described in the docs

AUTH_ACCESS_CONTROL_ALLOWED_EMAILS=bob@smith.com
AUTH_ACCESS_CONTROL_ALLOWED_EMAIL_DOMAINS=nhost.io,example.com

In the above example, users with the following emails would be able to register bob@smith.com, emma@example.com, john@nhost.io, whereas mary@firebase.com won't.

dbarrosop commented 2 months ago

I am afraid this change isn't correct. I am closing in favor of https://github.com/nhost/hasura-auth/pull/510