search

nhost / hasura-backend-plus

🔑Auth and 📦Storage for Hasura. The quickest way to get Auth and Storage working for your next app based on Hasura.
https://nhost.github.io/hasura-backend-plus/
MIT License
1.17k stars 187 forks source link

fix: support \n in JWT_KEY #492

Closed zbeyens closed 3 years ago

zbeyens commented 3 years ago

Issue

The env variable is keeping \n characters in its string.

Solution

Replace \n by an actual line break.

elitan commented 3 years ago

Can we provide some tests for t

johannesschobel commented 3 years ago

just curious, why this is with the JWT_KEY parameter, but not with the other params, like JWT_CLAIM or JWT_ALGORITHM?! 🤔

elitan commented 3 years ago

@zbeyens could you update this PR to merge into master (instead of master-old). We've been updating the branches a bit so that's why things are a bit out of sync in this PR.

johannesschobel commented 3 years ago

dear @elitan , just curious, why this issue appears on the JWT_KEY and not on the JWT_ALGORITHM parameter?! the PR that was merged will solve the issue (obviously) but does actually not target the real source of the issue, right?!

All the best

elitan commented 3 years ago

The JWT_ALGORITHM is not a long string containing potential \n.