Allowlist - Githubissues

komninoschatzipapas commented 3 years ago

Fixes #547.

elitan commented 3 years ago

Do we want to change the table name and endpoint from allowlist to something more related to registration specifically?

Naming it auth.allowlist does not make it clear that it's related to allow registrations. Some people might belive it's related to allow people to login, or to allow people to change password or something else?

nikolowry commented 3 years ago

Sorry for commenting again on an already merged PR, but it be great if either @komninoschat or @elitan could provide some clarifications on the following:

Is the final namespace of this feature settled on? I'm just a little confused with this PR being named "Allowlist" but all the ENV vars being prefixed with WHITELIST. Also, https://github.com/nhost/hasura-backend-plus/pull/555/files was closed without being merged or commented on. Maybe I missed the discussion, but is there a link to where this decision was discussed and reached?
Semi-related, but how long will _ENABLED and _ENABLE both be supported? There's a lack of consistency in the docs about which one we should ultimately prefer.

I really appreciate the project and how quick you've guys have been with communication and fixes. Thanks for the hard work!

elitan commented 3 years ago

It's going to be named whitelist.
We're moving from _ENABLE to _ENABLED so it's safe to start using _ENABLED.

Thanks for your kind words.

nhost / hasura-backend-plus

Allowlist #575