search

nhost / hasura-backend-plus

🔑Auth and 📦Storage for Hasura. The quickest way to get Auth and Storage working for your next app based on Hasura.
https://nhost.github.io/hasura-backend-plus/
MIT License
1.17k stars 187 forks source link

Has DATABASE_URL been dropped? #655

Open joshmedeski opened 3 years ago

joshmedeski commented 3 years ago

Has DATABASE_URL been dropped in the latest version of Hasura Backend Plus?

If so, it should be removed from the project completly:

$ rg "DATABASE_URL"

src/shared/migrations.ts
8:    connectionString: process.env.DATABASE_URL

src/test/global-setup.ts
10:    connectionString: process.env.DATABASE_URL

docker/dev/docker-compose-example.yaml
20:      HASURA_GRAPHQL_DATABASE_URL: >-
46:      DATABASE_URL: >-

docs/docs/getting-started/setup.md
47:      HASURA_GRAPHQL_DATABASE_URL: >-
69:      DATABASE_URL: >-

docker/dev/docker-compose-example2.yaml
19:      HASURA_GRAPHQL_DATABASE_URL: >-

docker/test/docker-compose-test.yaml
20:      HASURA_GRAPHQL_DATABASE_URL: >-
46:      DATABASE_URL: >-

I was using it previously and I didn't notice in the release notes that direct database communication was completely removed in a recent version of HBP.

joshmedeski commented 3 years ago

Okay, did some tests and found out the migration mechanism when the Docker container starts up is using it.