nhost / nhost-dart

Nhost Dart & Flutter packages
https://nhost.io
MIT License
91 stars 33 forks source link

feat(nhost_sdk): Allow metadata to be passed in signInWithSmsPassword… #123

Closed spakanati closed 11 months ago

spakanati commented 1 year ago

Fixes #100

Please note that I didn't add a test because currently the tests for SMS say "cannot meaningfully test" but please let me know if there is something that would be useful to add.

onehassan commented 12 months ago

@spakanati Thank you for the PR 🙌! Looking at it now.

onehassan commented 12 months ago

Hey @spakanati, I'm trying to include the other options as well not only the metadata. But I can't push to your repo because of permissions. If you can fix this on your end that would be great!

image
spakanati commented 12 months ago

@onehassan I just added you as a collaborator -- please let me know if you're able to push! Thanks so much for looking.

onehassan commented 12 months ago

Thank you @spakanati 🙌 , I was able to push changes. Will merge soon!