Regression: Zoom bubble is seen in omnibox after switching view in pdf files

nhotalling / pdfium

Automatically exported from code.google.com/p/pdfium

0 stars 0 forks source link

Regression: Zoom bubble is seen in omnibox after switching view in pdf files #15

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Version:37.0.2062.0 (Official Build 278856) 
OS:All (win 7-Aero enabled)

What steps will reproduce the problem?
1.Launch chrome and go to 
http://www.ets.org/Media/Tests/GRE/pdf/gre_research_validity_data.pdf
2.It opens a pdf then hover mouse on bottom right
3.Click on landscape or portrait view and observe

After switching to landscape or portrait view a zoom bubble is seen in omnibox

Zoom bubble should not be seen

This is regression, issue broken in 'M37' will update bisect soon

Note:Issue is applicable to any pdf files

Original issue reported on code.google.com by rk...@etouch.net on 24 Jun 2014 at 7:26

Attachments:

pdf_zoom_issue.jpg
[Expected_view change.mp4](https://storage.googleapis.com/google-code-attachments/pdfium/issue-15/comment-0/Expected_view change.mp4)
[Actual_view change.mp4](https://storage.googleapis.com/google-code-attachments/pdfium/issue-15/comment-0/Actual_view change.mp4)

GoogleCodeExporter commented 9 years ago

CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=277149%3A277157

suspecting: r277153 ?

Original comment by rk...@etouch.net on 24 Jun 2014 at 11:37

GoogleCodeExporter commented 9 years ago

this isn't related to pdfium, but to chrome's UI, so please file in chromium 
repo.

and yes this is r277153

Original comment by jam@chromium.org on 24 Jun 2014 at 7:45

GoogleCodeExporter commented 9 years ago

Yes, this seems to be an (unexpected) consequence of r277153. I believe this 
will be resolved when https://codereview.chromium.org/301733006/ lands.

Original comment by wjmacl...@chromium.org on 24 Jun 2014 at 7:58

GoogleCodeExporter commented 9 years ago

wjmaclean: can you confirm for sure?

Original comment by jam@chromium.org on 24 Jun 2014 at 8:11

GoogleCodeExporter commented 9 years ago

I tested a few minutes ago on Linux ToT with 301733006 and the extra bubbles 
were gone. I haven't tested on Windows though.

Original comment by wjmacl...@chromium.org on 24 Jun 2014 at 8:34

GoogleCodeExporter commented 9 years ago

Hi wjmaclean, is this issue resolved?

Original comment by bo...@foxitsoftware.com on 18 Jul 2014 at 7:43

Changed state: Started

GoogleCodeExporter commented 9 years ago

I checked on a ToT, and if I assume that when the bug description says "After 
switching to landscape or portrait view" it really means is"Switching between 
'fit page-width' and 'fit page-height' modes ...", then no, it doesn't seem to 
be fixed.

That being said, I think we were under the impression that the bubble was to be 
displayed anytime something other than the Chrome UI changed the zoom level, 
and in this case that's what's happening: the zoom change happens via 
PepperPluginInstanceImpl::ZoomChanged(). I seem to recall being told that the 
bubble should display when the + - zoom commands are invoked in the PDF viewer, 
which is the exact same pathway with nothing to distinguish between them.

I'd like to add some more people to this conversation (fsamuel@, dbeam@ to 
start) but I don't seem to have the necessary privilege ... can we perhaps move 
this to a crbug issue?

Original comment by wjmacl...@chromium.org on 18 Jul 2014 at 4:45

GoogleCodeExporter commented 9 years ago

Sure. Can you file a crbug issue and cc us? Thanks.

Original comment by bo...@foxitsoftware.com on 18 Jul 2014 at 4:48

GoogleCodeExporter commented 9 years ago

https://code.google.com/p/chromium/issues/detail?id=395182

I had to guess at your e-mails, since they're elided here ...

Original comment by wjmacl...@chromium.org on 18 Jul 2014 at 5:33

GoogleCodeExporter commented 9 years ago

Thanks. You got our emails right.

Original comment by bo...@foxitsoftware.com on 18 Jul 2014 at 6:10