search

nhovratov / content-blocks

TYPO3 CMS Content Blocks - Content Types API
https://docs.typo3.org/p/contentblocks/content-blocks/main/en-us/
GNU General Public License v2.0
52 stars 14 forks source link

AssetsCollector for backend (EditorPreview.html) do not add cache buster #79

Open kszymukowicz opened 5 months ago

kszymukowicz commented 5 months ago

When I add css in EditorPreview.html with cb:asset.css the css file is added but it has no cache buster. On Frontend.html everything works as expected and cache buster is added.

jonaseberle commented 5 months ago

Thank you! I see that also f:asset.css does not add the ?<timestamp> cache-buster to the URL in the backend. (It was added for the frontend in https://forge.typo3.org/issues/91889)

I wonder if that is because of this condition https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Page/AssetRenderer.php#L119-L121

jonaseberle commented 5 months ago

It was not that condition but

GeneralUtility::createVersionNumberedFilename($file) thinks the file does not exist https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Utility/GeneralUtility.php#L2035-L2037 image.

I think that might be a bug for AssetCollector assets in the backend?