search

nhovratov / jobfair

5 stars 3 forks source link

prevent an error if no attachment is provided in application #16

Closed ineswillenbrock closed 5 months ago

ineswillenbrock commented 1 year ago

In #11 I mentioned an error that I at first mistook to mean that multiple attachments where a problem. Investigating further I learned, that it's been the mail-creation-part in createApplicationAction() that had problems when no attachments where provided. I tried to solve it with first checking, if there is a file, and if yes, do as before. If there is no file, provide an empty string as the seventh variable ($fileName) to sendEmail() and don't try to delete any files. Yes, that might be a quick and dirty solution.

ineswillenbrock commented 1 year ago

How do I delete the 6 other commits from the PR? Those are from a sync of the two forks... The only relevant one is 1b2f7f5

nhovratov commented 1 year ago

How do I delete the 6 other commits from the PR? Those are from a sync of the two forks... The only relevant one is 1b2f7f5

You don't need to delete them now. Only the difference is relevant in "Files changed". I will squash the commit anyway.

Next time you can delete your old working branch and checkout the main branch. From there create a new branch for every new fix/feature