nhs-england-tools / repository-template

🛠️ 📚💡 This is a detailed and carefully made template for your GitHub projects. It's based on the wide knowledge and practical experience of the engineering community within NHS England. The template includes helpful suggestions, standards and practices - it's something you should consider using for all your repositories.
MIT License
31 stars 12 forks source link

Add sed and grep to the list of prerequisites #150

Closed stefaniuk closed 7 months ago

stefaniuk commented 9 months ago

Description

Add sed and grep GNU toolchain commands to the list of prerequisites.

Context

While setting up workstations with a new team, some scripts failed and it wasn't immediately apparent that the version of the sed command had to be GNU compliant.

Type of changes

Checklist


Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

regularfry commented 7 months ago

I'm not sure about that second commit. Ordinarily I'd say that tool names should be backticked, and the accept list should be used for actual words that vale doesn't know. Have we got something going on here where that doesn't work?