nhs-england-tools / repository-template

🛠️ 📚💡 This is a detailed and carefully made template for your GitHub projects. It's based on the wide knowledge and practical experience of the engineering community within NHS England. The template includes helpful suggestions, standards and practices - it's something you should consider using for all your repositories.
MIT License
31 stars 12 forks source link

Committing Dockerfile.effective? #154

Open regularfry opened 8 months ago

regularfry commented 8 months ago

I usually try to follow a rule of not committing generated files. Here, though, we say:

6. Commit all changes to these files

- `infrastructure/images/cypress/Dockerfile`
- `infrastructure/images/cypress/Dockerfile.effective`
- `infrastructure/images/cypress/VERSION`
- `.tool-versions`

Dockerfile.effective is a generated file. Is that an accidental inclusion, or is there a use case I've forgotten about?