nhs-england-tools / repository-template

🛠️ 📚💡 This is a detailed and carefully made template for your GitHub projects. It's based on the wide knowledge and practical experience of the engineering community within NHS England. The template includes helpful suggestions, standards and practices - it's something you should consider using for all your repositories.
MIT License
24 stars 11 forks source link

Use env vars for pre commit entries. #167

Open RossBugginsNHS opened 4 months ago

RossBugginsNHS commented 4 months ago

Description

pre-commit.yaml used args to try and pass the check type. However, these are expecting environment variables to be passed, not bash script parameters.

Context

Githooks not checking properly, and differences seen between githook and workflow checks. #166

Type of changes

Checklist


Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.