search

nhs-r-community / NHSRdatasets

NHS and healthcare related datasets for training and learning R
https://nhs-r-community.github.io/NHSRdatasets
Creative Commons Zero v1.0 Universal
66 stars 20 forks source link

Internal: Restructure ONS mortality data preparation workflow #69

Open francisbarton opened 7 months ago

francisbarton commented 7 months ago

Instead of multiple code sections for downloading CSV/XLS files that are then stored within the package directory, we should use functions that read in data directly from the URLs, process the data structures and bind them together without saving intermediate files to disk.

Or amend the workflow entirely to use the Nomis API.

However, the documentation for this package says that this data is for teaching purposes - I'm not sure if it's just the data itself that is used for this, or whether the data preparation process itself is part of a set of teaching materials.

I'm happy to do the work to amend the workflow for this dataset, if this issue is approved. But it would mean rewriting the current data preparation vignette as well.

chrismainey commented 7 months ago

I'm not sure this needs doing to be done, as you pointed out, because the original reason was to give NHS-like data for training. The was what Zoe used to prepare it, rather than being a workflow for people to follow. Depends on what you want to do with the package.