Closed tomjemmett closed 2 years ago
covr::report()
devtools::document()
lintr::lint_package()
styler::style_pkg()
this is to try to resolve #128 by making ptd_spc() a generic function with implementations for data.frame and SharedData.
ptd_spc()
data.frame
SharedData
the SharedData method hands all of the actual logic off to the data.frame method, which is the previous ptd_spc function.
ptd_spc
this needs some testing from someone with knowledge of {crosstalk} to ensure these changes work.
{crosstalk}
covr::report()(should aim for 100%)devtools::document()lintr::lint_package()and resolved all lint warnings and notesstyler::style_pkg()to make sure code matches the style guidelinesthis is to try to resolve #128 by making
ptd_spc()a generic function with implementations fordata.frameandSharedData.the
SharedDatamethod hands all of the actual logic off to thedata.framemethod, which is the previousptd_spcfunction.this needs some testing from someone with knowledge of
{crosstalk}to ensure these changes work.