nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme
https://nhs-r-community.github.io/NHSRplotthedots/
Other
48 stars 23 forks source link

update icons #163

Closed tomjemmett closed 2 years ago

tomjemmett commented 2 years ago

Switches to using icon files instead of the simple circles. Has the advantage of more closely matching the Excel tool, though there may be scaling issues with the icons being raster files and not vector graphics.

tomjemmett commented 2 years ago

This will work towards solving #162, by atleast using the standard icons. We may want to copy that table somewhere into the readme or the vignette?

NHSmatthewcallus commented 2 years ago

The icons were created with this PowerPoint file. Could you use this to create vector graphics?

Summary Icons.pptx

They are used in the MDC Power BI template and differ slightly from the Excel tool. The only noteworthy difference is with the purple icons – the arrows are directly up and down in the Excel tool, but the ones above are angled to the right to make them easier to differentiate in a summary table.

tomjemmett commented 2 years ago

used that powerpoint to generate SVG's, seems to be working. May need a bit of tweaking over time. Essentially, we need to load the SVG, render to a raster image, and add the raster to the plot (versus using pngs: we load a raster and add that to the plot).

Benefit of this approach is we could always render the icon to a sensible size before adding to the plot so we don't get scaling issues... at the moment though I render as a 100x100 pixel image and render that...

ThomUK commented 2 years ago

It looks great, Tom. I can't find any problems and I'd say ready to merge...

tomjemmett commented 2 years ago

Just re-running the Mac OS action... looked like it failed to start last time, rather than an issue with the code