Changed text to put link on the words and removed 'here'

nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme

Other

47 stars 21 forks source link

Closed Lextuga007 closed 1 year ago

Lextuga007 commented 1 year ago

[x] added unit tests and checked code coverage with covr::report() (should aim for 100%)
[x] ran devtools::document()
[x] ran lintr::lint_package() and resolved all lint warnings and notes
[x] ran styler::style_pkg() to make sure code matches the style guidelines
[x] ran R-CMD CHECK and resolved all issues

tomjemmett commented 1 year ago

Is this based off of #179? As that has some changes that will be in conflict to this (if it’s direct from main)

Lextuga007 commented 1 year ago

Oh I checked #176 and saw that was merged but not #179 and this is a branch off the current main.

Lextuga007 commented 1 year ago

I've made a change to a vignette, not README so there are no conflicts (I merged locally ok). Shall I leave this until you've done #179?

tomjemmett commented 1 year ago

ah, ok, I thought this change was needed in the readme. PR's are independent then, so I've marked that ready for review and will merge this now.

Lextuga007 commented 1 year ago

Good point! I'll make those changes.