nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme
https://nhs-r-community.github.io/NHSRplotthedots/
Other
47 stars 21 forks source link

internal: rename the mean column in ptd_spc_standard #187

Closed francisbarton closed 10 months ago

francisbarton commented 1 year ago

I think this column, created through a mutate step in ptd_spc_standard(),should be renamed. Calling it mean - the name of a common function - can lead to confusion and for me made some code harder to read and understand. Especially when the column name is referred to unquoted with NSE, it can look like the function mean() is being referred to.

I suggest renaming this to mean_col or something else more elegant.

Code I'm referring to: R/ptd_spc_standard.R#L70C4-L74C42

PR #188 will close this.