search

nhs-r-community / NHSRplotthedots

An SPC package to support NHSE/I 'Making Data Count' programme
https://nhs-r-community.github.io/NHSRplotthedots/
Other
47 stars 22 forks source link

should arguments use tidyeval? #62

Closed tomjemmett closed 3 years ago

tomjemmett commented 3 years ago

currently arguments like dateField and valueField to spc() are passed as strings, but as most people will be used to using tidyverse style functions (e.g. mutate) which expect symbols rather than strings, should we switch to using tidyeval?

tomjemmett commented 3 years ago

same as #53 - this feels like the kind of design decision we will be stuck with after first release.

tomjemmett commented 3 years ago

having had brief discussions with @chrismainey / @chrisreading01, I'll give this a go! This shouldn't be an epic like my last PR at least...