search

nhs-r-community / NHSRtheme

R package that helps to create plots that follow the NHS Identity
https://nhs-r-community.github.io/NHSRtheme
Other
28 stars 9 forks source link

Add custom xaringan theme files, resolve #12 #13

Closed spcanelon closed 3 years ago

spcanelon commented 3 years ago

Thank you for your contribution to the nhsrtheme repo. Before submitting this PR, please make sure:

spcanelon commented 3 years ago

Wonderful, thank you!

And if I may, I think keeping the YAML output syntax consistent with all of the xaringan documentation would help with learning (and teaching!) xaringan. I can appreciate how having a custom nhsr_presentation function would be convenient, but it means creating more of a black box for people getting acquainted with this new Rmarkdown output. Also, being able to see the same YAML structure as referenced in the xaringan css wiki, for example, could be more encouraging for people wanting make their own unique modifications to the css.

What do you think?

tomjemmett commented 3 years ago

yes, agreed. I copied something I was building for an in-house theme where this is less of a concern. I'm thinking of doing some overrides of the default arguments but documenting these changes (things like defaulting to 16:9). There may be a few things that we need to force though (seal = FALSE, self_contained = TRUE). In these cases provide error messages if the user tries to override.