nhs-r-community / NHSRtheme

R package that helps to create plots that follow the NHS Identity
https://nhs-r-community.github.io/NHSRtheme
Other
28 stars 10 forks source link

Should this package be renamed in the NHSRpackage format? #24

Closed Lextuga007 closed 3 years ago

Lextuga007 commented 3 years ago

Other packages are now in the format NHSRpackage rather than nhsrpackage. Should this one be renamed?

tomjemmett commented 3 years ago

it's a good point... I created this a fair while back and didn't think much to the name. The issue now is some people have already installed this, so renaming could be an issue. But as it isn't released, it's not the biggest issue ever. Would be good to get some thoughts/opinions from others (@ChrisBeeley, @chrismainey, happy to chime in?)

ChrisBeeley commented 3 years ago

I don't much like the NHSRpackage name format, but I don't think renaming is an issue- I don't think this package is in production on too many servers 😉

Lextuga007 commented 3 years ago

😄 dare I ask what format you do like?! I just went with the NHSRpackage format as many of the packages are like that, including those on CRAN. Consistency is key 🚀

ChrisBeeley commented 3 years ago

Camel case, like on our repos!

tomjemmett commented 3 years ago

I tend to prefer snake_case, but package names can't be snake_case... I really dislike randoMcAsE (like you tend to see with capital R's in package names)... I think going to NHSR... is the best option as that's what we have used for other packages now. I'll rename this