search

nhs-r-community / demos-and-how-tos

A repo for community contributed demos and how-tos to get common stuff done in the R language
https://nhs-r-community.github.io/demos-and-how-tos/
MIT License
29 stars 13 forks source link

PR edit #55

Closed ChrisBeeley closed 1 year ago

ChrisBeeley commented 1 year ago

I've tidied up PR #54 a bit and made a new PR against main.

Sorry, I should have made a proper PR against the fork really, but I only realised that halfway through.

See what you think

ChrisBeeley commented 1 year ago

@Lextuga007 please review and squash merge to remove the unwanted files

Pablo-source commented 1 year ago

Thanks for the suggestions and update @ChrisBeeley and @Lextuga007, I have been looking into what a squash merge is, my next pull request will be neater and tidier !

ChrisBeeley commented 1 year ago

We appreciate your time on this ☺️

Pablo-source commented 1 year ago

I am glad to be able to contribute to the wider NHS-R Community. Currently my team only works with Tableau, but R is my passion !

Lextuga007 commented 1 year ago

Thanks for your patience on this while I got around to having a look. There are a few comments I'm going to make to the code and because there are so many files (which is brilliant!) the PR may take a bit of time to work through but I hope it'll be a learning experience for us both!

Don't worry too much about the commit history, that comes with time and a Squash is useful way of tidying up.

ChrisBeeley commented 1 year ago

I love this PR! Excellent work on both sides :clap: :clap: :clap: