The format_dob will need addressing as there are a number of strings that will not return the correct output. Handful of these are as below:
test_value <- "25-12-2021"# fails
test_value <- "25/12/2021"# fails
test_value <- "25-dec-2021"# fails
test_value <- "25/dec/2021"# fails
test_value <- "25/december/2021"# fails
test_value <- "25-december-2021"# fails
test_value <- "25-DECEMBER-2021"# fails
It now returns yyyymmdd format.
Can someone do a review, please?
Sorry, even though this PR related to 11 changes but only format_dob.R needs review. I ran styling fix so it looks like loads of changes but I only need format_dob.r file to be reviewed.
(testthat folder has list of test I have done - all passed).
5 related.
The format_dob will need addressing as there are a number of strings that will not return the correct output. Handful of these are as below: test_value <- "25-12-2021"# fails test_value <- "25/12/2021"# fails test_value <- "25-dec-2021"# fails test_value <- "25/dec/2021"# fails test_value <- "25/december/2021"# fails test_value <- "25-december-2021"# fails test_value <- "25-DECEMBER-2021"# fails
It now returns yyyymmdd format.
Can someone do a review, please? Sorry, even though this PR related to 11 changes but only format_dob.R needs review. I ran styling fix so it looks like loads of changes but I only need format_dob.r file to be reviewed. (testthat folder has list of test I have done - all passed).