nhsbsa-data-analytics / personMatchR

Helper package for matching individuals across two datasets
Apache License 2.0
0 stars 0 forks source link

5 dob validation #18

Closed kygoffe closed 2 years ago

kygoffe commented 2 years ago

5 related.

Give order to the format to capture American-style time as the last matching. (for example, 07/03/2021 could be read as 20210307 or 20210703).

steven-buckley commented 2 years ago

In the case of a non-valid entry being included what should the outcome be: a) stop matching process b) convert invalid entries to null c) leave invalid as they are and allow matching (will this cause problems using the edit distance of 2 criteria)

kygoffe commented 2 years ago

@steven-buckley , please review and if you are happy then merge, please!

steven-buckley commented 2 years ago

All looks good, happy to merge