nhsconnect / FHIR-NOO-API

FHIR based API for managing National Opt Out preferences
https://nhsconnect.github.io/FHIR-NOO-API/index.html
Apache License 2.0
0 stars 2 forks source link

Update consent - collision detection #31

Open InteropAdmin opened 6 years ago

InteropAdmin commented 6 years ago

Is it intentional that there is no provision for update collision detection

dxh73 commented 6 years ago

Is this where two clients attempt to update one resource at the same time ?

The expectation with NDOP is that when the Opt-out is set, it will be left like that and not change. Its not a service where a resource will be updated on a regular basis, if at all, and the chances of a collision are so small that this has not been highlighted as a concern. I think FHIR has something called optimistic locking (can't check, FHIR website down) which may address the risk of collisions. I'll look into this and see whether this is an option.

dxh73 commented 6 years ago

I've asked the question to the TA's and Thunderbird tea, about collision detection to establish if this is a requirement. Optimistic locking, using e-Tag and if-Match would address this and could be added if the risk of a collision is a concern.