search

nhsconnect / FHIR-NOO-API

FHIR based API for managing National Opt Out preferences
https://nhsconnect.github.io/FHIR-NOO-API/index.html
Apache License 2.0
0 stars 2 forks source link

Fix STU3 URLs #4

Closed ahatherly closed 6 years ago

ahatherly commented 6 years ago

Hi, I've updated the resources in quite a few places to correct the STU3 URLs, and also put the actual CodeSystem URLs in - hopefully I've done it all right! Adam.

IOPS-DEV commented 6 years ago

Hi Adam, Couple of things to mention. First, my develop branch was way out of date. I'd gone a bit rouge and updated changes directly on gh-pages branch rather than develop. That said, the problems you fixed still existed on gh-pages. I'll spend some time this morning and get git updated and sync'd up, and make sure I only work on develop branch and merge into gh-pages from now on.

dxh73 commented 6 years ago

Hi Adam,

Develop and gh-pages are now sync'd back up. This will have changed the codesystems, valuesets and example. The url structure for codesystem I've left the way we had it, but that's not to say it's the correct way (we're still learning about STU3 changes).

ahatherly commented 6 years ago

Cool – sorry if I caused issues for you ☺

Adam.

Adam Hatherly Senior Technical Architect Domain D - Interoperability NHS Digital

adam.hatherly@nhs.netmailto:adam.hatherly@nhs.net 0113 397 4164 07920 861 737 www.digital.nhs.ukhttp://www.digital.nhs.uk/ @NHSDigital

General enquiries: 0300 303 5678 enquiries@nhsdigital.nhs.ukmailto:enquiries@nhsdigital.nhs.uk

From: Dave Henderson [mailto:notifications@github.com] Sent: 11 September 2017 11:07 To: nhsconnect/FHIR-NOO-API Cc: HATHERLY, Adam (NHS DIGITAL); Author Subject: Re: [nhsconnect/FHIR-NOO-API] Fix STU3 URLs (#4)

Hi Adam,

Develop and gh-pages are now sync'd back up. This will have changed the codesystems, valuesets and example. The url structure for codesystem I've left the way we had it, but that's not to say it's the correct way (we're still learning about STU3 changes).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nhsconnect/FHIR-NOO-API/pull/4#issuecomment-328484156, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADPAR6nFvyV4qttnaqKKMyPU0JIM8V0xks5shQZJgaJpZM4PRgZP.

This message may contain confidential information. If you are not the intended recipient please inform the sender that you have received the message in error before deleting it. Please do not disclose, copy or distribute information in this e-mail or take any action in relation to its contents. To do so is strictly prohibited and may be unlawful. Thank you for your co-operation.

NHSmail is the secure email and directory service available for all NHS staff in England and Scotland. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services.

For more information and to find out how you can switch, https://portal.nhs.net/help/joiningnhsmail

dxh73 commented 6 years ago

Hi Adam, No probs, just the opposite. It's highlighted issues within CS, VS and the example that I'd missed, which shows the importance of a review. I also need to get into the habit of working with git in the right way. A few lessons learned in the project.