nhsconnect / FHIR-NOO-API

FHIR based API for managing National Opt Out preferences
https://nhsconnect.github.io/FHIR-NOO-API/index.html
Apache License 2.0
0 stars 2 forks source link

Consent element references to be corrected in IG and examples. #8

Open dxh73 opened 6 years ago

dxh73 commented 6 years ago

Consent contains two references; patient and organization. In order for these to meet FHIR standard, the URL must contain a FHIR resource within the reference e.g https://demographics.spineservices/Patient/6101231234

IG and examples need to be updated to reflect this.

ahatherly commented 6 years ago

I think you'll want this to include the FHIR version in the URL - i.e. https://demographics.spineservices.nhs.uk/STU3/Patient/6101231234

dxh73 commented 6 years ago

Thanks Adam. I'm not 100% sure if the STU3 needs to be added. It's not a FHIR server that's being referenced, so in theory I don't need to provide a FHIR version. The reason /Patient/ is in there, is to meet the FHIR spec on literal references, that states any reference points to a FHIR resource whether or not the endpoint is a FHIR RESTful server. It's a valid point you've made, and one I didn't think about, so I'll get a definitive answer before making any changes to the IG.

ahatherly commented 6 years ago

It will be a FHIR endpoint once the PDS FHIR API is developed - hence why it needs to follow the same policy as all other FHIR endpoints.

dxh73 commented 6 years ago

Thanks Adam.

dxh73 commented 6 years ago

Patient and Organization references have been updated within the IG to include FHIR version and resource.

swk003 commented 6 years ago

What is the expected delivery date for PDS FHIR API? Does NOO live rollout have a dependency on PDS/ ODS APIs?

dxh73 commented 6 years ago

NDOP has no dependency on any other API and there is not current requirement to resolve any references at this time, although I understand that there will be in the future.