search

nhsconnect / gpconnect-provider-testing

GP Connect automated test suite for API providers
Apache License 2.0
11 stars 5 forks source link

Minor changes required to test suite in 1.2.3 #257

Closed Sado1234 closed 5 years ago

Sado1234 commented 5 years ago

Raised this ticket to encompass minor tweaks that can be grouped into one release or added onto another.

  1. Need to add assertion of expected OperationOutcome resource with error code "ORGANISATION_NOT_FOUND" OrganizationReadFeature.OrganizationReadWithValidIdentifierWhichDoesNotExistOnProvidersSystem test to be updated

  2. The diagnostic details of the error in the OperationOutcome.diagnostics property should be displayed as "diagnostics" currently displayed as "text" (same for 0.5.2 and 0.7.x)

Sado1234 commented 5 years ago

1) updated test to check error code "ORGANISATION_NOT_FOUND" 2) As spec states SHOULD not able to validate this test but confirmed that each version now returns Diagnostics: SHOULD provide additional diagnostic details of the error in the OperationOutcome.diagnostics property where such details securely provide additional error context for consumer applications.

Sado1234 commented 5 years ago

Code committed closing ticket