Removal of 300 seconds JWT expiry time tests from the automated test suite

nhsconnect / gpconnect-provider-testing

GP Connect automated test suite for API providers

Apache License 2.0

11 stars 5 forks source link

Removal of 300 seconds JWT expiry time tests from the automated test suite #285

Open AndrewGuiseley opened 5 years ago

AndrewGuiseley commented 5 years ago

As agreed, please can the following 2 tests be removed from the automated test suite:

Expiry Time - greater than 300 seconds Expiry Time - less than 300 seconds

Providers should only be validating that the exp claim value (i.e. that this time has not yet passed)

jonnyry commented 5 years ago

Just to mention the demonstrator intentionally continues to perform these checks (as additional consumer validations), whereas the provider systems are not expected to.

Sado1234 commented 5 years ago

Hi @jonnyry what are your thoughts, instead of deleting we place these type of tests in a 'DemonstratorFeature' file to continue checking the Demonstrator functionality?

PeterGresty commented 5 years ago

DemonstratorOnly.feature maybe - for even more clarity

jonnyry commented 5 years ago

Yes sounds like a reasonable idea. So long as the providers are clear they don't need to run the tests.