search

nhsconnect / nrls-reference-implementation

Reference Implementation of NRLS providers and consumers
Apache License 2.0
1 stars 2 forks source link

Searching on invalid (non English/Welsh or Test) NHS Number causes a 400 error #3

Open KevinMayfield opened 6 years ago

KevinMayfield commented 6 years ago

Searching on a test NHS Numbers e.g.

https://data.developer.nhs.uk/nrls-ri/DocumentReference?subject=https%3A%2F%2Fdemographics.spineservices.nhs.uk%2FSTU3%2FPatient%2F9476719958

works fine and returns a Bundle with no entries and response code 200

However searching using a non English/Welsh NHS Number causes an error. e.g.

https://data.developer.nhs.uk/nrls-ri/DocumentReference?subject=https%3A%2F%2Fdemographics.spineservices.nhs.uk%2FSTU3%2FPatient%2F1352465790

On both javascript and java clients this puts the clients in error handling code - although the API call has worked. I believe the correct FHIR/REST API behaviour would be to return a 200 response code and a bundle with no entries)

KevinMayfield commented 6 years ago

possibly related to https://github.com/nhsconnect/gpconnect-demonstrator/issues/110