Critical emergency pull request

nhsengland / ckanext-nhsengland

NHS England CKAN skin

GNU Affero General Public License v3.0

2 stars 5 forks source link

Critical emergency pull request #7

Closed rossjones closed 9 years ago

rossjones commented 9 years ago

Uppercase format names on search page, was driving me nuts

ntoll commented 9 years ago

OK... I'm not sure what the emergency is. Also, if upper-case is driving you nuts why are you introducing .upper(). Surely that's a .lower() you want in there..? ;-)

rossjones commented 9 years ago

They were mixed, some upper, some lower. Now all upper

ntoll commented 9 years ago

Oh, I realise that... I'm just thinking of your mental health here matey... Surely that's LIKE HAVING THE UI SHOUT AT YOU ALL THE TIME!!!!!11!1!!1!! :-)

Totally agree it should be consistent, why not go for the far more chilled out lower()..? Think of the amount of stress we'll be reducing as a result.

rossjones commented 9 years ago

Lower is too hard to read on that page, Upper just looks better :)