search

nhsengland / ckanext-nhsengland

NHS England CKAN skin
GNU Affero General Public License v3.0
2 stars 5 forks source link

NHS Dashboard Integration /dash #8

Closed nathanhebe closed 9 years ago

nathanhebe commented 9 years ago

Initial integration via plugin of the NHS England Dashboard v1

ntoll commented 9 years ago

From the CKAN/Python point of view this is exactly what we're looking for. If you're happy, then I'm happy. :-)

Since you said you were going to make further changes I'll wait to merge into our master branch until you give me the nod (as a comment on here I guess).

Cheers.

nathanhebe commented 9 years ago

Hi ntoll, I've sent an email with description, but happy for you to complete this pull request now

ntoll commented 9 years ago

Hi,

So it's deployed (https://data.england.nhs.uk/dash) but I can't see anything. Obviously there's a bug. Happy to help in any way that I can.

N.

ntoll commented 9 years ago

OK... turns out that Firefox was blocking something. It looks great! :-)

ntoll commented 9 years ago

OK... looking around, I notice there are some missing graphical elements - e.g. I see a broken image on the finance page.

ntoll commented 9 years ago

OK... hard coded URL to other instance was causing the Firefox collywobbles. See the email David sent and my reply.