search

nhshackday / nhshackday.github.io

NHS Hack Day website
http://nhshackday.com
13 stars 22 forks source link

Specify minimum Jekyll version required to build the site #240

Closed davidmiller closed 5 years ago

davidmiller commented 6 years ago

Disclaimer: I couldn't Ruby my way out of a paper bag, this could be utterly the wrong thing to do.

When running bundle install; bundle exec jekyll serve prior to this change to the Gemfile I get errors about the use of the {% link tag which was introduced in this version.

multipurposebot commented 6 years ago

Latest Travis CI automatic staging build of this PR: https://240-pr-nhshackday-github-io-nhshackday.surge.sh

blu3id commented 6 years ago

The github-pages gem specifies the minimum (an maximum) Jekyll version... so I would suggest (also a ruby novice) that this is a local issue. Did you delete your Gemfile.lock and then run bundle install it should automatically pull appropriate versions...

I say this because the Travis environment (which is built pragmatically) seems to get the dependencies right?

davidmiller commented 6 years ago

Did you delete your Gemfile.lock

I did not... will try that...

blu3id commented 5 years ago

Going to close this as fairly sure this is Gemfile.lock issue/ not run bundle update github-pages also #246 now provides for alternative/reproducible environment for running locally.