search

nhsuk / betahealth

Rendering application for beta symptom and condition pages
https://beta.nhs.uk
MIT License
2 stars 8 forks source link

Update hidden text component #331

Closed teneightfive closed 7 years ago

teneightfive commented 7 years ago

This adds an indentation and left border to distinguish text that has been revealed.

Before

screen shot 2017-03-08 at 10 43 46 screen shot 2017-03-08 at 11 00 57

After

screen shot 2017-03-08 at 10 44 22 screen shot 2017-03-08 at 11 00 32

Potential problems

Images

[EDIT]: This is no longer an issue after the changes made in #334.

The image cards now stack when this extra padding is included. This could potentially be addressed by an alternative way of removing the images from the reveal and using a different method to hide/show more graphic images. We have discussed using a blur and an action to reveal the image.

screen shot 2017-03-08 at 10 28 47

Inside binary lists

The more we nest content the less readable it seems to become. Maybe an alternative is to review the use of the side by side lists when they have large amounts of content and a reveal like this.

screen shot 2017-03-08 at 10 28 29
Demotive commented 7 years ago

screen shot 2017-03-08 at 11 05 01

If it's of any interest, at the moment in Register with a GP we're treating them in a sort of "callout" fashion. It's to give distinction from the main transaction, and show them as hi-viz when you use them.

Subject to change etc, but just throwing it in here.

teneightfive commented 7 years ago

334 now uses a fluid version of the gallery now which will solve the issue of a gallery nested within a progressive disclosure.