search

nhsuk / ci-deployment

MIT License
6 stars 5 forks source link

Errors in CI log for profiles/master #53

Closed neilbmclaughlin closed 7 years ago

neilbmclaughlin commented 7 years ago

Spotted this in the build log for profiles/master:

travis_time:end:0a5cccf9:start=1500630665090590744,finish=1500630671431371854,duration=6340781110
travis_fold:end:cache.2
travis_fold:start:after_success
travis_time:start:089240d4
$ bash ./scripts/deploy.sh
Cloning into 'scripts/ci-deployment'...
Installing Rancher (v0.6.1)
Loading answers from ./scripts/ci-deployment/common/answers/10-defaults.sh
Loading answers from ./scripts/ci-deployment/travis/answers/10-defaults.sh
Loading answers from ./scripts/ci-deployment/travis/answers/20-vault-travis.sh
Retrieving default variables from path: /v1/secret/defaults. Status 200
Retrieving default variables from path: /v1/secret/dev/defaults. Status 200
Retrieving default variables from path: /v1/secret/defaults/profiles/env-vars. Status 200
jq: error (at <stdin>:1): string ("CACHE_TIME...) and number (3600) cannot be added
Retrieving default variables from path: /v1/secret/dev/profiles/env-vars. Status 404
jq: error (at <stdin>:1): string ("CACHE_TIME...) and number (3600) cannot be added
Travis detected
Building Docker tags:  latest master
travis_fold:start:Building_Docker_Images
travis_fold:start:Login_to_Docker_hub
Login Succeeded
travis_fold:end:Login_to_Docker_hub
travis_fold:start:Building_Default_Image
Building default image
Sending build context to Docker daemon 13.38 MB

It didn't cause the build to fail.

neilbmclaughlin commented 7 years ago

From @adamgraves-choices:

Ah yeah, all numbers have to be double quoted to force them to be strings. We can change the jq command to convert it to a string also. If you raise a github issue for it, I'll sort it when I get back.

adamgraves-choices commented 7 years ago

Closed by https://github.com/nhsuk/ci-deployment/pull/54