search

nhsuk / connecting-to-services

Find a pharmacy
https://www.nhs.uk/service-search/find-a-pharmacy/
MIT License
2 stars 9 forks source link

Use id rather than identifier for deduping #221

Closed st3v3nhunt closed 7 years ago

st3v3nhunt commented 7 years ago

Within the dedupe function https://github.com/nhsuk/connecting-to-services/blob/master/app/lib/dedupePharmacies.js#L8 identifier is used to check for uniqueness. When the API is using docDB for its data source the returned items will include id which is a copy of identifier.

This change opens up the possibility for the dedupe function to use id which has the knock on effect of the API being able to change to not request and return the identifier property.

st3v3nhunt commented 7 years ago

No longer relevant as docDB is not going to be used by the API