search

nhsuk / nhsuk-frontend

NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.
https://nhsuk.github.io/nhsuk-frontend/
MIT License
616 stars 107 forks source link

Header #169

Closed chrimesdev closed 5 years ago

chrimesdev commented 5 years ago

Header

Use this issue to discuss the Header component.

Preview the header component Preview the transactional header component Preview the header with navigation only component Preview the header with search only component

Find out more about the header component and when to use it in the NHS Digital service manual.

See our contributing guidelines

davidhunter08 commented 5 years ago

There is an issue with the menu button placement in the header when a 'long' service name is used.

screencapture-xlasercut-github-io-nhsuk-frontend-vue-2019-04-08-09_52_26

The code can be seen at https://xlasercut.github.io/nhsuk-frontend-vue/

This has also highlighted the issue of the menu button placement when there is no search button.

header-no-search

header-no-search-inspect

The menu button should align right (of the container) when there is no search button.

header-no-search-aligned
damonjagger commented 5 years ago

Some of the NHS services I work on use a different organisational logo.

It would be useful if we could extend the logo part of the header for those services.

I haven't done any testing to see what the impact of doing this would be in the current iteration of the header component. But it's something I'd like to see in the wagtail nhsuk frontend.

chrimesdev commented 5 years ago

Closing these individual placeholder issues.

Please use the NHS digital service manual backlog to discuss the usage of this component. If you're having trouble with the code, or have found a bug, please raise an issue on the NHS.UK frontend backlog