search

nhsuk / nhsuk-frontend

NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.
https://nhsuk.github.io/nhsuk-frontend/
MIT License
623 stars 107 forks source link

Header macro should allow you to set the aria-label #288

Closed GrilloPress closed 5 years ago

GrilloPress commented 5 years ago

Currently using the header macro (from packages/components/header/template.njk)you get the default NHS website aria label and cannot change it.

The label overrides the content you locally set meaning that on a service using this macro, assisted tech users would get "NHS homepage" announced instead of whatever override I wish to set (service name etc.)

image

The aria-label is on line 4 of packages/components/header/template.njk

Possibly could default to NHS website unless given a specified override, or maybe a service name

mcheung-nhs commented 5 years ago

Fair point @GrilloPress - we'll look at making the aria-label an argument that can be overridden, with 'NHS homepage' as the default.

mcheung-nhs commented 5 years ago

@GrilloPress - Functionality available in the latest release: https://github.com/nhsuk/nhsuk-frontend/releases/tag/0.5.3