Emergency Banner - Githubissues

nhsuk / nhsuk-frontend

NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.

https://nhsuk.github.io/nhsuk-frontend/

MIT License

623 stars 107 forks source link

Emergency Banner #54

Closed davidhunter08 closed 6 years ago

davidhunter08 commented 6 years ago

Use this issue to refactor the component: Emergency Banner

Breaking changes

Class nhsuk-c-global-alert__header is now nhsuk-c-global-alert__heading

Refactor checklist

[x] Sass file contains comments, using the comments template format
[x] Refactor code using BEM for naming
[x] Remove / refactor any code smells
[x] Remove / refactor any 'random numbers' or make comments where it is necessary to use

Component checklist

[x] SCSS
[x] SCSS lint
[x] HTML template
[x] HTML validate & lint
[x] Nunjucks macro
[x] A standalone example
[x] README/Documentation
[x] Pseudocode tests
[x] Visual tests
[x] Tested against our testing policy (Resolution, Browser & Accessibility)
[x] Print stylesheet considered
[x] CHANGELOG

chrimesdev commented 6 years ago

Need someone to write up the emergency banner API logic, the required javascript and how to implement it on website and services.