nhsuk / nhsuk-frontend

NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.

https://nhsuk.github.io/nhsuk-frontend/

MIT License

606 stars 106 forks source link

Error summaries should only be programatically focusable, not keyboard focusable #944

Open edwardhorsford opened 2 months ago

edwardhorsford commented 2 months ago

Bug Report

The GOV.UK Error summary is only focusable programatically - JS is used to focus it on page load.

The NHS Error summary is different in that it's currently keyboard focusable. From a conversation on NHS slack it sounds like this is because the GOV.UK one has had an update since the NHS one was produced.

What is the issue?

I don't think there's any reason for the error summary to be keyboard focusable - and it's probably good to mirror the GOV.UK one.

andymantell commented 2 months ago

For reference, it got added to govuk in January 2022: https://github.com/alphagov/govuk-frontend/commit/e1b17e0af8da11d9db72cbd99020444d69d9c4cc

Which was after our initial port of the JS: https://github.com/nhsuk/nhsuk-frontend/commit/268e164609d0452b2bcca076b1c21740a69a7177