nhsuk / nhsuk-frontend

NHS.UK frontend contains the code you need to start building user interfaces for NHS websites and services.
https://nhsuk.github.io/nhsuk-frontend/
MIT License
619 stars 107 forks source link

Label bottom margins are too large #947

Closed edwardhorsford closed 4 months ago

edwardhorsford commented 4 months ago

Bug Report

The bottom margins on the label modifiers are too large. On GOV.UK they're set to align with the fieldset legend bottom margins - but on the NHS design system they use much larger responsive margins. The result is that the label looks too visually distant from the input or hint.

You can see the discrepancy on this page when you compare fieldset legends to labels - they should all look approximately the same distance from the form fields.

XL label xl-before

L label l-before

M label m-before

S label s-before

Is there anything else you think would be useful in recreating the issue?

Here's GOV.UK's code for labels.