search

nhsuk / nhsuk-service-manual-community-backlog

This is a place for digital teams in the NHS to work together and develop the NHS digital service manual.
https://service-manual.nhs.uk/community-and-contribution
62 stars 5 forks source link

Review back link and breadcrumb spacing and positioning #526

Closed anandamaryon1 closed 2 months ago

anandamaryon1 commented 5 months ago

What

Currently the back link component requires the use of modifier classes to add the correct margins around it. The breadcrumbs component differs in that it contains its own padding and therefore must be placed in a different location within the HTML than the back link, which is inconsistent.

Therefore, it looks like we should consider updating the two components together, updating their spacing and defining their position within the HTML. This maybe require changes to the page template guidance too.

Related issues

Back link https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/32 Breadcrumbs: https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/6 Page template: https://github.com/nhsuk/nhsuk-service-manual-community-backlog/issues/200 nhsuk-frontend PR: https://github.com/nhsuk/nhsuk-frontend/pull/964

anandamaryon1 commented 2 months ago

Released as part of v7.0.0: https://github.com/nhsuk/nhsuk-service-manual/pull/2040