search

nhsuk / nhsuk-service-manual

Design and build digital services for the NHS. Use the service manual to build consistent, usable services that put people first.​ Learn from the research and experience of other NHS teams.
https://service-manual.nhs.uk
MIT License
64 stars 25 forks source link

CSS, JavaScript and assets being imported from node_modules #191

Closed chrimesdev closed 5 years ago

chrimesdev commented 5 years ago

The CSS on the code snippet examples and the JavaScript/assets are being directly imported from the node_modules into pages. These should be compiled within the application via Sass/ES6 modules to give us more flexibility and customisation if we require.

chrimesdev commented 5 years ago

The JavaScript on regular pages is also being imported directly from the NHS.UK frontend node_module folder <script src="/service-manual/nhsuk-frontend/nhsuk.min.js" defer></script>