search

nhsuk / nhsuk-service-manual

Design and build digital services for the NHS. Use the service manual to build consistent, usable services that put people first.​ Learn from the research and experience of other NHS teams.
https://service-manual.nhs.uk
MIT License
65 stars 25 forks source link

Warning callout - aria-label="Important" #635

Closed mgifford closed 4 years ago

mgifford commented 4 years ago

I'm not sure that this is a best practice. If it is, I'm not sure why it isn't in the HTML example provided https://service-manual.nhs.uk/design-system/components/warning-callout

I'm pretty sure that the aria-label would sound much like: <h3 class="nhsuk-warning-callout__label">Important: School, nursery or work</h3>

and not provide any additional semantic meaning for screen reader users. Just looking at the definitions & examples here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute

As you probably know, there's lots of discussion about labels here https://github.com/alphagov/govuk-design-system-backlog/issues/71

davidhunter08 commented 4 years ago

Thanks @mgifford.

We're currently looking into this with the NHS.UK frontend https://github.com/nhsuk/nhsuk-frontend/pull/630

Once we're happy with the solution, we'll release the code and update the guidance on the service manual.

davidhunter08 commented 4 years ago

Closed issue because of issue 664