search

nhsuk / wagtail-nhsuk-frontend

A wagtail implementation of the NHS.UK frontend library
MIT License
21 stars 13 forks source link

Why not page chooser in blocks with URL field #174

Open nickmoreton opened 3 years ago

nickmoreton commented 3 years ago

Hi, thanks for this work! More of a question than an issue but is there a reason the blocks that have URL fields don't have page chooser implemented. I'd like to add that into a project Im working on and wondering if to add the feature here or stay with extending them in the project only.

mikemonteith commented 3 years ago

Thanks for the feedback @nickmoreton We have never had the need for a page chooser on ActionLinkBlock or PromoBlock just because the way our site works, those blocks always link to external sites.

I think it would be good to add a page-chooser and some custom validation so that either page chooser or URL has to have a value.

Pull requests welcome 😄

nickmoreton commented 3 years ago

Thanks for the reply @mikemonteith Yes I thought it would be a good idea too. Will get working on it and kill 2 birds with one stone :)