Review open issues and pull requests and decide what to do with them - Githubissues

nhsuk / wagtail-nhsuk-frontend

A wagtail implementation of the NHS.UK frontend library

MIT License

21 stars 13 forks source link

Review open issues and pull requests and decide what to do with them #193

Closed chrimesdev closed 3 years ago

chrimesdev commented 3 years ago

Description

[x] Review open issues and pull requests and decide what to do with them

Related to

https://github.com/nhsuk/nhsuk-service-manual/issues/1159

DomBaker commented 3 years ago

Started taking a look at the open issues and pull requests related to the wagtail plug-in
In the process of finding any inconsistencies with the NHS.UK front-end.

DomBaker commented 3 years ago

Some of the findings are as followed,

Inconsistent naming in relation to components in the Wagtail CMS, for example, Right panel, Left panel (Naming should be closely coupled with the front-end library for ease of understanding each component).

To Be Removed

Panel block - Complete - 20/04/2021 - https://github.com/nhsuk/wagtail-nhsuk-frontend/pull/194
Grey Panel Block - Complete - https://github.com/nhsuk/wagtail-nhsuk-frontend/pull/194
Panel List Block - Complete - https://github.com/nhsuk/wagtail-nhsuk-frontend/pull/194
Promo Block
Promo Group Block

Current missing components, Forms, Tables, Nav A to Z, List Panel (More to add). (In adding these will reduce the main CMS's custom styling and workaround code).
Backward compatibility (Getting a better understanding of what will break while rectifying some of these issues, backward compatibility is somewhat important, but, functionality in line with the latest Front-end Library version is more so).