search

nhsuk / wagtail-nhsuk-frontend

A wagtail implementation of the NHS.UK frontend library
MIT License
21 stars 13 forks source link

Wagtail 3.0 support #236

Closed BrianXu20 closed 2 years ago

BrianXu20 commented 2 years ago

Fix https://github.com/nhsuk/wagtail-nhsuk-frontend/issues/235

Tests:

https://user-images.githubusercontent.com/73645085/174240191-c0d412ea-bc0c-4de6-8231-8e32f7e37cfa.mov

mikemonteith commented 2 years ago

This is amazing thanks @BrianXu20 and @nickmoreton! 🔥 I'm away today so I'll review it properly on Monday.

jamesdellis commented 2 years ago

Hey @mikemonteith, any update on that review?

nickmoreton commented 2 years ago

Thank you @BrianXu20. My only suggestion is to keep INSTALL_REQUIRES at 2.0

Hi @mikemonteith thank you for the review. I have reverted the version here back to 2.0

nickmoreton commented 2 years ago

Hi @mikemonteith I hope you are well. Can you tell me if there will be a new release for the Wagtail 3 compatibility? Thank you.

mikemonteith-livi commented 2 years ago

@nickmoreton https://github.com/nhsuk/wagtail-nhsuk-frontend/pull/237 Just waiting for an approver