search

nhsuk / wagtail-nhsuk-frontend

A wagtail implementation of the NHS.UK frontend library
MIT License
21 stars 13 forks source link

Missing label in admin for warning callout & capitalisation of letters #95

Closed chrimesdev closed 5 years ago

chrimesdev commented 5 years ago

When in the Wagtail admin and selecting the Warning callout component, the field for the body content does not have a label next to it - it's just a box aligned to the left so I don't know what I am supposed to be entering.

I'm guessing its body content so I would expect the field to have a label of Body: similar to other components. (See screenshot)

Also a small thing but for consistency, for the Action link component, do we need to capitalize the first letter so 'Link text' and 'External URL' - also something to note is that the link is always necessarily an external URL. eg. Find a pharmacy is still the NHS website.

Screenshot 2019-04-10 at 14 14 43
chrimesdev commented 5 years ago

After speaking to Ben and Mike, we may need a 'Title' field on the Warning callout as we want this to be customised - by default (if blank) it will be 'Important'

See example here: https://nhsuk.github.io/nhsuk-frontend/components/warning-callout/index.html

Ross-Clark commented 5 years ago

I also noticed a lack of labels on the inset text, which i will fix as a part of this issue

chrimesdev commented 5 years ago

Closed - this is done and will be in the next release.