search

nhsx / AnalyticsUnit

What we'll do, are doing, have done
https://nhsx.github.io/AnalyticsUnit/
MIT License
5 stars 3 forks source link

Initial Blog Upload & Gemfile Update #15

Closed JRPearson500 closed 3 years ago

mbfons commented 3 years ago

Thanks @JRPearson500 , this looks good to me. I edited some typos and also included a couple of sub-header info (date, author, link to git). I committed directly to your branch which I probably shouldn't have, sorry for that (I guess I should've cloned your branch and made a pull request on top of that?)

On another note - I think at some point the 'Thinking' posts will need some staging similar to the 'Projects'? Just to structure / tidy a bit up by themes, e.g. 'New tools and techniques' ; 'Ways of working' ; 'PhD internships' or something like that.

JRPearson500 commented 3 years ago

New branch and PR not needed for small tweaks - so your approach was fine.

I've got the ability to do this already coded in but all set to "interested" at the moment. So can click the switch easily at some point.

On Tue, 12 Oct 2021 at 13:35, mbfons @.***> wrote:

Thanks @JRPearson500 https://github.com/JRPearson500 , this looks good to me. I edited some typos and also included a couple of sub-header info (date, author, link to git). I committed directly to your branch which I probably shouldn't have, sorry for that (I guess I should've cloned your branch and made a pull request on top of that?)

On another note - I think at some point the 'Thinking' posts will need some staging similar to the 'Projects'? Just to structure / tidy a bit up by themes, e.g. 'New tools and techniques' ; 'Ways of working' ; 'PhD internships' or something like that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nhsx/AnalyticsUnit/pull/15#issuecomment-940971622, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFHF3CZIW5DIOBUCNQC3KLUGQTS3ANCNFSM5FYCDILQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Jonny Pearson

M: 07783817751

E: @.***

-- This e-mail and any attachments is intended only for the attention of the addressee(s). Its unauthorised use, disclosure, storage or copying is not permitted. If you are not the intended recipient, please destroy all copies and inform the sender by return e-mail.  

mbfons commented 3 years ago

I have now also reviewed 'expeiernces.md' and corrected some minor typos / formatting issues. I'll accept the merge request. The Google Drive has some commentary on what was changed (or minor things that could be changed), but not crucial. Thanks!